#3189 - handle defaults in Spring placeholders #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3190 +/- ##
============================================
+ Coverage 92.91% 92.91% +<.01%
- Complexity 3512 3513 +1
============================================
Files 382 382
Lines 9330 9334 +4
Branches 768 769 +1
============================================
+ Hits 8669 8673 +4
Misses 472 472
Partials 189 189
|
dilipkrish
approved these changes
Jan 6, 2020
|
Thank you @beliakou! |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Issue #3189
Are there unit tests? If not how should this be manually tested?
Few test cases added
Any background context you want to provide?
As per http://springfox.github.io/springfox/docs/snapshot/#property-file-lookup there is support for Spring properties resolution but default values like
${propertyName:defualt}are not handled. I'm wondering if there are other places I need to update?What are the relevant issues?
Issue #3189