New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2932 #3210
Closed
Closed
Issue 2932 #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@alienisty Is this a duplicate of? #3159 |
It looks like it addresses the same issue.
Last time I checked spring boot was 2.2.1 and I made the change for that
version, so I guess 3159 is more up to date.
Alessandro (Alex) Nistico
alienisty@gmail.com
"Any system like Eternity, which allows men to choose their own future,
will end
by choosing safety and mediocrity, and in such a Reality the stars are out
of reach."
The End of Eternity - Isaac Asimov
…On Thu, 12 Dec 2019 at 20:31, Andreas Kluth ***@***.***> wrote:
@alienisty <https://github.com/alienisty> Is this a duplicate of? #3159
<#3159>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3210?email_source=notifications&email_token=AA7J37DYV5W3T3LSVYZUUQ3QYIVJFA5CNFSM4JZXIX22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGWQPAQ#issuecomment-564987778>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7J37DLPIFNT3KTLZXLONDQYIVJFANCNFSM4JZXIX2Q>
.
|
@alienisty thank you for this PR. Closing this one, but would you still be up for a new PR for the gradle build system changes still in this PR that is useful? |
Duplicate of #3159 |
@dilipkrish,
do you refer to the commit for fixing the plugin for eclipse?
…On Mon, 6 Jan 2020 at 20:20, Dilip Krishnan ***@***.***> wrote:
@alienisty <https://github.com/alienisty> thank you for this PR. Closing
this one, but would you still be up for a new PR for the gradle build
system changes still in this PR that is useful?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3210?email_source=notifications&email_token=AA7J37FBBZI7E4P3H3M32QDQ4MOZNA5CNFSM4JZXIX22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFJKZY#issuecomment-571118951>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7J37HHE5QH77D5ZAENKBTQ4MOZNANCNFSM4JZXIX2Q>
.
|
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do/fix?
Adds compatibility with Spring Boot 2.2.1
Are there unit tests? If not how should this be manually tested?
All existing tests pass
Any background context you want to provide?
Small improvement/changes in the way endpoints are named
What are the relevant issues?
#2932