Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The setup.py in windows can cause a encoding error. #98

Closed
a358003542 opened this issue Jun 2, 2018 · 2 comments · Fixed by #99
Closed

The setup.py in windows can cause a encoding error. #98

a358003542 opened this issue Jun 2, 2018 · 2 comments · Fixed by #99
Labels
bug Something isn't working
Milestone
Nice to have

Comments

@a358003542
Copy link

This will be corrected by :

with open('README.md', encoding='utf8') as f:
    long_description = f.read()
@thibaudcolas thibaudcolas added the bug Something isn't working label Jun 4, 2018
@thibaudcolas thibaudcolas added this to the Nice to have milestone Jun 4, 2018
@thibaudcolas
Copy link
Collaborator

thibaudcolas commented Jun 4, 2018 •
edited

Hey @a358003542, thanks for raising this.

I'm not sure how best to test this but I'll try to make a fix.

thibaudcolas added a commit that referenced this issue Jun 4, 2018
@thibaudcolas
Use io.open with utf-8 encoding in setup.py. Fix #98
130aa47
@thibaudcolas thibaudcolas mentioned this issue Jun 4, 2018
Merged
thibaudcolas added a commit that referenced this issue Jun 4, 2018
@thibaudcolas
Use io.open with utf-8 encoding in setup.py. Fix #98 (#99)
9b01295
@thibaudcolas thibaudcolas mentioned this issue Jun 4, 2018
Merged
@thibaudcolas
Copy link
Collaborator

@a358003542 this should now be released as v2.1.2 on PyPI if you want to give it another try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Nice to have
Development

Successfully merging a pull request may close this issue.

Use io.open with utf-8 encoding in setup.py. Fix #98 springload/draftjs_exporter
2 participants
@thibaudcolas @a358003542