Next #188
Merged
Next #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change names of AccordionItemTitle and AccordionItemBody
Rename `accordion` prop to `allowMultipleExpanded`
Unify 'onChange' behaviour
…cordionContainer type
Feature/allow zero expanded
Chore/puppeteer
Remove any mention of undocumented feature 'disabled'
…e and expanded=true
Remove unused 'classnames' dependencies
Chore/remove badges
Bump package.json to 3.0.0
Merged
Chore/changelog
… key in package.json
ryami333
requested review from
vincentaudebert,
samanthaksanders,
catepalmer,
holloway,
janzenz,
katie-day,
ldanet and
michelmattos
|
This is amazing work @ryami333! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Changelog does a better job of summarising this PR than I could hope to do here, so please go there to see a list of changes.
For the most part, I would imagine that this PR will be very difficult to analyze by the diffs, as it's yet another wholesale refactor (almost a re-write, really). I would recommend that, if you have the time, you checkout the branch and assess it in a vacuum.
Thanks for taking the time to help review this PR!