Change names of AccordionItemTitle and AccordionItemBody #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy to AccordionItemPanel
ryami333
suggested changes
Jan 16, 2019
ryami333
approved these changes
Jan 16, 2019
|
Nicely done, merge away 🍷 |
ryami333
pushed a commit
that referenced
this pull request
Jan 16, 2019
Change names of AccordionItemTitle and AccordionItemBody
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request gives a potential fix to #150, which suggested that aligning component names with the WAI-ARIA spec to remove ambiguity would be a good idea. Have renamed
AccordionItemTitletoAccordionItemHeadingandAccordionItemBodytoAccordionItemPanel, along with the corresponding CSS class names (accordion__titleandaccordion__body).At this stage I've just replaced all the component names entirely (as a breaking change) rather than as a deprecation (with the old component names still exported to alongside the new ones, but with warnings). If it still seems like a good idea to do this as a deprecation, the old names could be added back with that functionality.