DraftailTextBlock to be searchable #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a bit of a bummer that we have to render the html to then strip it but I don't see how else it can be done. The JSON structure doesn't seem very easy to traverse. Would DraftailTextField need the same fix? |
|
Yes, the text field implementation should be updated as well. |
|
About having to render the content first - it's not a biggie, since wagtail database search backend doesn't support extra fields anyways, whereas Elasticsearch takes the stuff from fields only once - at the indexing stage (it's either on model update, or even in a celery/cron background job) |
loicteixeira
force-pushed
the
feature/block_to_be_searchable
branch
from
cdd1020
to
5932461
Compare
|
Will add tests as part of in #27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently DraftTextBlock returns its JSON stuff as the searchable content.
We want it to be the rendered document instead.