Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Back-end tests #27

Merged
merged 4 commits into from
Apr 24, 2017
Merged

[WIP] Back-end tests #27

merged 4 commits into from
Apr 24, 2017

Conversation

loicteixeira
Copy link
Contributor

@loicteixeira loicteixeira commented Apr 3, 2017 •
edited

Ref #11 .

@loicteixeira loicteixeira mentioned this pull request Apr 3, 2017
Merged
dnsl48
dnsl48 previously requested changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibaudcolas should we fix tests before merging?

@dnsl48 dnsl48 dismissed their stale review April 5, 2017 04:00

It seems to be passing now (I just rerun travis)

@loicteixeira
Copy link
Contributor Author

Haven't got much time to add more tests. Merging this in as it's better than nothing (current coverage of 70%).

@loicteixeira loicteixeira merged commit 3780249 into master Apr 24, 2017
@loicteixeira loicteixeira deleted the chore/tests-all-the-things branch April 24, 2017 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnsl48 dnsl48 dnsl48 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loicteixeira @dnsl48