Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/avoid user controlled input #381

Merged

Conversation

timonback
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for springwolf-ui canceled.

Name Link
🔨 Latest commit 7745384
🔍 Latest deploy log https://app.netlify.com/sites/springwolf-ui/deploys/653be5fe9734be00085af33a

@timonback timonback marked this pull request as draft September 29, 2023 14:45
@timonback
Copy link
Member Author

The schemaService does not return the FQN of the java class, therefore this code does not work as expected as this point.

Idea for the next release: We change the schema name to the FQN of the class.
This also resolves the issue when multiple classes with different FQN, but same simpleName are found that both exist in the final AsyncApi document (instead of last-write-wins)

@timonback timonback force-pushed the refactor/avoid-user-controlled-input branch from 0d16db3 to 6c3eba1 Compare October 27, 2023 15:54
@timonback timonback marked this pull request as ready for review October 27, 2023 15:54
@timonback timonback merged commit 90ea6dd into springwolf:master Oct 27, 2023
13 checks passed
@timonback timonback deleted the refactor/avoid-user-controlled-input branch October 28, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant