Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist CSS #71

Closed
joegaudet opened this issue Sep 15, 2011 · 7 comments
Closed

Blacklist CSS #71

joegaudet opened this issue Sep 15, 2011 · 7 comments

Comments

@joegaudet
Copy link
Contributor

Similar to the Blacklist that removes .js files that aren't used, it would be nice to have a way to guard against some of the default css being included that is not needed for my app. Or ultimately is being overriden, so for example I have my own style for SC.ButtonView that is pervasive throughout the app, it would be nice to be able to remove the additional css given that our current css payload is about 600 kb + 200 kb the 600kb is all SC.

.joe

@ialexi
Copy link
Contributor

ialexi commented Sep 15, 2011

You can already do this: Whitelist/Blacklist works on both CSS and JS

Also, do you have Ace in addition to your own theme? If so, if your styling is all custom (rather than a variant of Ace) you don't need it; change it to SC.BaseTheme.create() (instead of AceTheme) and in your build file, set :theme to :theme => 'sproutcore/empty_theme'

@joegaudet
Copy link
Contributor Author

OIC, cool. Now I just need the proxying error we keep seeing to get resolved and we will be cooking.

.joe

@joegaudet
Copy link
Contributor Author

Which version of Abbot officially had Blacklist support ?

@ialexi
Copy link
Contributor

ialexi commented Sep 20, 2011

I think 1.6 may have had some support, but it was broken (in that it used a different format than it should have). 1.7 has support.

@joegaudet
Copy link
Contributor Author

On a related note, how do I go about removing the ace theme from the SC build.

I changed my theme to not use ace anymore, but rather EmptyTheme, however it still seems to package / send the ace SC stuff.

Do I need to black list it ?

.joe
On 2011-09-20, at 3:44 PM, Alex Iskander wrote:

I think 1.6 may have had some support, but it was broken (in that it used a different format than it should have). 1.7 has support.

Reply to this email directly or view it on GitHub:
#71 (comment)

@ialexi
Copy link
Contributor

ialexi commented Sep 21, 2011

You shouldn't need to... have you changed :theme in your app's build file to be :theme => 'sproutcore/empty_theme'?

@ialexi
Copy link
Contributor

ialexi commented Sep 21, 2011

(Ace is just a target like any other; it has to be included via either :required => or :theme =>; by default, all apps default to :theme => "sproutcore/ace", but if that's turned off, there's no reason it should get included)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants