Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphenate package names #121

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Hyphenate package names #121

merged 1 commit into from
Mar 29, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Mar 24, 2021

For consistency, update the wasm and cbindings package names to use hyphenation.

  • didkit_wasmdidkit-wasm
  • didkit_cbindingsdidkit-cbindings

@clehner clehner marked this pull request as ready for review March 24, 2021 19:05
@clehner clehner requested a review from theosirian March 24, 2021 19:06
@wyc
Copy link
Contributor

wyc commented Mar 24, 2021

is this the preferred rust package naming convention? i looked it up online and saw some discussion

https://rust-lang.github.io/rfcs/0940-hyphens-considered-harmful.html
rust-lang/api-guidelines#29
rust-lang/cargo#2775
rust-lang/book#1709
rust-lang/cargo#6700

after reading all this stuff, i'm still not sure what's best. i guess choose your own adventure, but it should be consistent for all our packages!

@clehner
Copy link
Contributor Author

clehner commented Mar 26, 2021

@wyc thanks for those links. Some additional useful discussion and links are in unicode-org/icu4x#304.

I am favoring hyphenated package names where possible, and agree on consistency.


Summarizing some of the points, for reference…

In favor of hyphen:

In favor of underscore:

Doesn't matter:

  • Cargo registry (Alternative Registries excepted) treats them equivalent.
  • More things might start treating them as equivalent.

@wyc
Copy link
Contributor

wyc commented Mar 27, 2021

Appreciate the great summary. I am happy with the outcome of hyphenated links.

@wyc wyc self-requested a review March 27, 2021 16:22
@clehner
Copy link
Contributor Author

clehner commented Mar 29, 2021

Rebased.

@clehner clehner merged commit 7900c7b into main Mar 29, 2021
@clehner clehner deleted the fix/package-names branch March 29, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants