Prepare didkit crate for publishing to crates.io #139
Conversation
| did-sol = { path = "../../ssi/did-sol" } | ||
| did-web = { path = "../../ssi/did-web" } | ||
| did-onion = { path = "../../ssi/did-onion" } | ||
| ssi = { version = "0.2", path = "../../ssi", default-features = false } |
There was a problem hiding this comment.
Did we want to use the ssi package on crates.io?
There was a problem hiding this comment.
not sure if it can be done, but wouldn't it be nice if we first check if it exists on this path and as fallback go to crates?
There was a problem hiding this comment.
This change makes didkit use the ssi package on crates.io when didkit is stilled from crates.io. When it is used locally, it will still require ssi to be cloned alongside the didkit repo. I don't think we can make the use of the local path conditional on the path existing (although I thought that was how it works, testing now shows it is not the case).
We could decouple didkit from ssi even for local git use, by removing the path = parts here. This could make it easier for people developing didkit, to not need ssi. But this could make it a little harder to develop didkit and ssi at the same time (having to edit Cargo.toml to add back the path = parts). I don't this question is blocking these changes, since these changes are incremental and do not break the existing usage.
Reference: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#multiple-locations
The git or path dependency will be used locally (in which case the version is checked against the local copy), and when published to a registry like crates.io, it will use the registry version.
There was a problem hiding this comment.
Opened issue for this: #141
There was a problem hiding this comment.
I'm okay keeping this for now, thanks for making the issue!
- Add package metadata - Include only the Rust source files - Depend on ssi crates on registry
clehner
force-pushed
the
feat/didkit-crate
branch
from
7bde5ff
to
1e67958
Compare
Progress for #119
/lib.crates.ioregistry versions.Publish dry-run succeeds with this command: