Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use did:key for peer IDs #151

Merged
merged 1 commit into from
Jul 20, 2023
Merged

use did:key for peer IDs #151

merged 1 commit into from
Jul 20, 2023

Conversation

chunningham
Copy link
Member

Description

Currently peers are represented in delegations by URIs of the form peer:<PEER-ID>, which is neither a proper URI or a DID. This PR adds a way to get a did:key DID of a peer. At the moment this is mostly an aesthetic change as we don't use peer IDs, but it's a change we should make before we start using the Peers keys to sign things

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Diligence Checklist

(Please delete options that are not relevant)

  • This change requires a documentation update
  • I have included unit tests
  • I have updated and/or included new integration tests
  • I have updated and/or included new end-to-end tests
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chunningham chunningham merged commit 7373d67 into main Jul 20, 2023
12 of 13 checks passed
@chunningham chunningham deleted the feat/did-key-peers branch July 20, 2023 09:48
chunningham added a commit that referenced this pull request Jul 20, 2023
@chunningham chunningham mentioned this pull request Jul 20, 2023
12 tasks
chunningham added a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants