Fix KV behaviour. #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunningham
added a commit
that referenced
this pull request
Mar 23, 2022
* rename OrbitMetadata -> Manifest * clean up Manifest type, parse from did doc * update auth methods, use DID str as OID, remove CREATE params * add ResourceId type for parsing * update auth token handling * fallback to verification methods if no capability vms * move Manifest to file, impl `Orbit::new` * use resource and orbit ids in auth tokens * move to named orbits/peer groups * load based only on path, disable allowlist route * fix allowlist, change to return an OrbitId * update to libp2p-0.43 * use ResourceIds as sole rep of invocation targets/actions * fix zcap test * Fix KV behaviour. (#93) * use codecs enum instead for resourceId CID Co-authored-by: Charles Cunningham <charlescunningham@Charless-MBP.fritz.box> Co-authored-by: Charles Cunningham <charlescunningham@Charless-MacBook-Pro.fritz.box> Co-authored-by: Jacob <93085583+cobward@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are optional functions on the trait that are equivalent to those that were removed. In the long term we might want to make more use of the ConnectionHandler, but I need to spend more time understanding exactly what that is for.