-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ethers resolving to version 5.5.1 only #68
Comments
We moved ethers to a peer dependency but it should not be fixed at 5.5.1
(this should just be the floor). As a workaround you could use this version
in your project (if possible). Will work on a release asap.
…On Thu, Apr 7, 2022, 3:47 AM safisaleem ***@***.***> wrote:
Hi, when I upgrade to the latest version of siwe - 1.1.6, I get the
following errors when trying to npm install:
$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: <redacted>
npm ERR! Found: ***@***.***
npm ERR! node_modules/ethers
npm ERR! ethers@"^5.5.4" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer ethers@"5.5.1" from ***@***.***
npm ERR! node_modules/siwe
npm ERR! siwe@"1.1.6" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/safisaleem/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/safisaleem/.npm/_logs/2022-04-07T06_40_14_031Z-debug.log
any suggestions?
—
Reply to this email directly, view it on GitHub
<#68>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBSTQGZVNAIU4ZKXA3YBRDVD2AGBANCNFSM5SYJZDHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@safisaleem does this issue still exist? otherwise we will close this. |
https://github.com/spruceid/siwe/pull/58/files fixed this in theory, but anyone using the npm registry will still have the issue because #58 doesn't seem to have been published yet |
agree with what @joewagner said |
siwe/packages/siwe/package.json Line 30 in 6a9a8a2
Unfortunately, Having this library only work with v5 or only work with v6 is going to cause notable pain for some ever-changing portion of the developer base over time. |
Thanks for the heads up here on a lot of this - we'll work to address! |
This issue is fixed in our beta release of siwe 2.0.3. Now the dependency is:
I hope that works for you, then we can close this issue. |
|
If I do |
@MicahZoltu Ok, we will close this issue and created a new one for ethers 6 upgrade path. |
Hi, when I upgrade to the latest version of siwe -
1.1.6
, I get the following errors when trying tonpm install
:any suggestions?
The text was updated successfully, but these errors were encountered: