ethers resolving to version 5.5.1 only

[safisaleem]

Hi, when I upgrade to the latest version of siwe - 1.1.6, I get the following errors when trying to npm install:

$ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: <redacted>
npm ERR! Found: ethers@5.6.2
npm ERR! node_modules/ethers
npm ERR!   ethers@"^5.5.4" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer ethers@"5.5.1" from siwe@1.1.6
npm ERR! node_modules/siwe
npm ERR!   siwe@"1.1.6" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/safisaleem/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/safisaleem/.npm/_logs/2022-04-07T06_40_14_031Z-debug.log

any suggestions?

[w4ll3]

We moved ethers to a peer dependency but it should not be fixed at 5.5.1 (this should just be the floor). As a workaround you could use this version in your project (if possible). Will work on a release asap.

…

On Thu, Apr 7, 2022, 3:47 AM safisaleem ***@***.***> wrote: Hi, when I upgrade to the latest version of siwe - 1.1.6, I get the following errors when trying to npm install: $ npm i npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: <redacted> npm ERR! Found: ***@***.*** npm ERR! node_modules/ethers npm ERR! ethers@"^5.5.4" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer ethers@"5.5.1" from ***@***.*** npm ERR! node_modules/siwe npm ERR! siwe@"1.1.6" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution. npm ERR! npm ERR! See /Users/safisaleem/.npm/eresolve-report.txt for a full report. npm ERR! A complete log of this run can be found in: npm ERR! /Users/safisaleem/.npm/_logs/2022-04-07T06_40_14_031Z-debug.log any suggestions? — Reply to this email directly, view it on GitHub <#68>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBSTQGZVNAIU4ZKXA3YBRDVD2AGBANCNFSM5SYJZDHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[awoie]

@safisaleem does this issue still exist? otherwise we will close this.

[joewagner]

https://github.com/spruceid/siwe/pull/58/files fixed this in theory, but anyone using the npm registry will still have the issue because #58 doesn't seem to have been published yet

[safisaleem]

agree with what @joewagner said

[MicahZoltu]

ethers is still hard coded to 5.5.1 on main:

siwe/packages/siwe/package.json

Line 30 in 6a9a8a2

"ethers": "5.5.1"

Unfortunately, ethers v6 is now in beta and I believe it changes the public surface area a bit which might end up in things breaking if someone uses a v6 peer dependency. I don't know if NPM will allow major version changes to peer dependencies automatically with ^5.51 or not, but regardless of whether it does or not I think there needs to be a solution for the transition from ethers v5 to v6, which is likely to happen very slowly across the ecosystem.

Having this library only work with v5 or only work with v6 is going to cause notable pain for some ever-changing portion of the developer base over time.

[obstropolos]

ethers is still hard coded to 5.5.1 on main:

siwe/packages/siwe/package.json

Line 30 in 6a9a8a2

"ethers": "5.5.1"

Unfortunately, ethers v6 is now in beta and I believe it changes the public surface area a bit which might end up in things breaking if someone uses a v6 peer dependency. I don't know if NPM will allow major version changes to peer dependencies automatically with ^5.51 or not, but regardless of whether it does or not I think there needs to be a solution for the transition from ethers v5 to v6, which is likely to happen very slowly across the ecosystem.

Having this library only work with v5 or only work with v6 is going to cause notable pain for some ever-changing portion of the developer base over time.

Thanks for the heads up here on a lot of this - we'll work to address!

[awoie]

This issue is fixed in our beta release of siwe 2.0.3. Now the dependency is:

"ethers": "^5.5.1"

I hope that works for you, then we can close this issue.

[MicahZoltu]

^ will only do minor and patch updates. It won't do major updates. You can do >5.5.1 would work, but I believe that ethers 6 is not fully API compatible with ethers 5, so I recommend testing before moving forward with this strategy.

[joewagner]

"ethers": "^5.5.1"

I hope that works for you, then we can close this issue.

If I do npm install siwe@beta the issue is fixed for me, Thanks!

[awoie]

^ will only do minor and patch updates. It won't do major updates. You can do >5.5.1 would work, but I believe that ethers 6 is not fully API compatible with ethers 5, so I recommend testing before moving forward with this strategy.

@MicahZoltu Ok, we will close this issue and created a new one for ethers 6 upgrade path.