Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIWE Release 2.0.4 #79

Merged
merged 4 commits into from
Jul 18, 2022
Merged

SIWE Release 2.0.4 #79

merged 4 commits into from
Jul 18, 2022

Conversation

w4ll3
Copy link
Member

@w4ll3 w4ll3 commented May 12, 2022 •
edited

@awoie awoie requested a review from skgbafa May 25, 2022 14:04
@w4ll3 w4ll3 marked this pull request as ready for review May 25, 2022 14:05
skgbafa
skgbafa reviewed May 25, 2022
View reviewed changes
Copy link
Contributor

@skgbafa skgbafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PRs this release includes look good and the changes here look good. Ran the tests locally and they passed, but it looks like the test runner fails somehow on this release branch, but not on main. I think this is worth checking out before merging!

skgbafa
skgbafa approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@skgbafa skgbafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An expected error! We can look at how to display it better when tests run.

@joewagner joewagner mentioned this pull request Jun 21, 2022
Closed
@obstropolos obstropolos requested a review from sbihel July 6, 2022 13:29
sbihel
sbihel approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to do a rebase merge and not squash all the commits

@w4ll3
Version bump
b8e1ead
@w4ll3
Adds linter and lint the files. (#78)
d8edbf1 
* Add linter and apply format

* Removed useless try catch block

* Made promise function not async, renamed assert to fail changed let to const

* Fix linter issues with tests

* Type provider for checkContractWalletSignature
@w4ll3
Unwraps SiweResponse for validate function (#84)
ae95658 
* Updates package version

* Unwraps SiweMessage for legacy function
@w4ll3
Add tests for validate function (#88)
d9f845b
@w4ll3 w4ll3 merged commit f65e540 into main Jul 18, 2022
@w4ll3 w4ll3 deleted the release/2.0.4 branch July 18, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skgbafa skgbafa skgbafa approved these changes

@sbihel sbihel sbihel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@w4ll3 @skgbafa @sbihel