Generate types for EthereumEIP712Signature2021 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs a refresh/update as discussed on today's call, to both the upstream eip712 issues and the test cases |
clehner
force-pushed
the
feat/eip712sig-tests
branch
from
14b8180
to
cc2bfea
Compare
sbihel
approved these changes
Mar 2, 2022
sbihel
approved these changes
Mar 2, 2022
For EthereumEIP712Signature2021
clehner
force-pushed
the
feat/eip712sig-tests
branch
from
28a1142
to
223c3ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement EIP-712 type generation for linked data proof suite as being specified in w3c-ccg/ethereum-eip712-signature-2021-spec#25. Test test vectors added in w3c-ccg/ethereum-eip712-signature-2021-spec#26 and with minor updates in w3c-ccg/ethereum-eip712-signature-2021-spec#43.
Discrepancy found: https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/25/files#r711353493. Test vectors verified, with workarounds.proofobject, if needed. Proposed test vectors do not currently includeproofin the data to be signed: https://github.com/w3c-ccg/ethereum-eip712-signature-2021-spec/pull/26/files#r710072926. The check for untyped properties is disabled to allow validating the test vectors, but this causes CI failure.