Default disallow example non-DID VC issuer #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VC Test Suite requires being able to issue a verifiable credential out of a test vector credential whose issuer property is https://example.edu/issuers/14.
ssi
checks verification relationship when issuing verifiable credentials. But this checking expects a DID URI as issuer, which resolves to a DID document, that contains verification material. In the case of a HTTP issuer URI (URL), something analogous should probably be done, but we don't have support for that yet. So for thisexample.edu
HTTP issuer, the check is simply skipped, and for all HTTP issuers, an error is raised. This behavior addresses the current requirements. However, it might not be advisable to allow the check to be skipped in this case, outside thevc-test-suite
test driver that requires it. Typically, handling of an example URL like this might be gated by a#[cfg(test)]
attribute. However, thevc-test-suite
test driver is run as an executable, so I don't think that the test configuration option can be used here. Instead, this PR adds a new feature for it,example-http-issuer
. This feature is then disabled by default but enabled for use in thessi-vc-test
package.