Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default disallow example non-DID VC issuer #316

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Sep 29, 2021

VC Test Suite requires being able to issue a verifiable credential out of a test vector credential whose issuer property is https://example.edu/issuers/14.

ssi checks verification relationship when issuing verifiable credentials. But this checking expects a DID URI as issuer, which resolves to a DID document, that contains verification material. In the case of a HTTP issuer URI (URL), something analogous should probably be done, but we don't have support for that yet. So for this example.edu HTTP issuer, the check is simply skipped, and for all HTTP issuers, an error is raised. This behavior addresses the current requirements. However, it might not be advisable to allow the check to be skipped in this case, outside the vc-test-suite test driver that requires it. Typically, handling of an example URL like this might be gated by a #[cfg(test)] attribute. However, the vc-test-suite test driver is run as an executable, so I don't think that the test configuration option can be used here. Instead, this PR adds a new feature for it, example-http-issuer. This feature is then disabled by default but enabled for use in the ssi-vc-test package.

src/one_or_many.rs Outdated Show resolved Hide resolved
@clehner clehner merged commit 5f9647d into main Oct 18, 2021
@clehner clehner deleted the fix/example-issuer-feature branch October 18, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants