Restrict Revocation List allowed URL schemes #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hold off til override methinks, lots of people use DIDKit in secure environments/PoCs and would need the override! |
chunningham
approved these changes
Oct 4, 2021
|
Rebasing and merging... Re-allowing HTTP revocation list loading is being tracked in #320 |
clehner
force-pushed
the
fix/revocation-list-protocol-security
branch
from
f4ea255
to
dffe8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revocation List 2020 doesn't say what is a URL. But examples and test vectors use
https. This implementation has been allowinghttpalso. For a more secure default, this PR changes it to allow onlyhttps.We could later add some option or mode for allowing HTTP where it is safe and necessary to do so, and/or other protocols/schemes.
If merged, a change similar to this one should be made in the implementation of Status List 2021 in #278.