Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates gnosis modal to completely load contents before showing to av… #98

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

krhoda
Copy link
Contributor

@krhoda krhoda commented Mar 1, 2023

…oid a flash in the UI

Description

Updates where the modal is shown to avoid issues with it flashing grey in the UI. Tested locally using ssx-test-dapp, additional testing would be appreciated, because I wasn't able to reproduce on my own.

Type

  • Bug fix (non-breaking change which fixes an issue)

Diligence Checklist

  • I have performed a self-review of my code
  • My changes generate no new warnings

@krhoda krhoda requested review from Juliano1612 and w4ll3 and removed request for Juliano1612 March 1, 2023 18:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (4cef197) 90.34% compared to head (c6c9766) 90.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   90.34%   90.36%   +0.02%     
==========================================
  Files          25       25              
  Lines        3336     3343       +7     
  Branches      270      270              
==========================================
+ Hits         3014     3021       +7     
  Misses        322      322              
Impacted Files Coverage Δ
packages/ssx-gnosis-extension/src/modal.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Juliano1612
Copy link
Member

Looks good to me! Unit and E2E tests passing, and ssx-test-dapp working as expected.

@krhoda Can you add a changelog for ssx-gnosis-extension like this? You just need to run yarn changeset from the root folder.

@krhoda
Copy link
Contributor Author

krhoda commented Mar 3, 2023

Added a changeset as requested @Juliano1612 !

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2023

CLA assistant check
All committers have signed the CLA.

@obstropolos obstropolos merged commit 0274cdf into spruceid:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants