Feat/generalize claims #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs a small change to the search viewer, but otherwise works from creation to deployment and includes clear way to add editing of exiting claims in the future. |
krhoda
force-pushed
the
feat/generalize-claims
branch
from
de9f226
to
055f616
Compare
Deploying with
|
| Latest commit: |
0a4a818
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23fe61d8.tzprofiles.pages.dev |
sbihel
requested changes
Jun 14, 2021
There was a problem hiding this comment.
- There's no change to the package.json but the lock file changed -- should we agree on a npm version so we don't get those changes constantly? I'm personally using
7.7.6 - You pushed a compiled WASM module from webpack, was that on purpose?
dapp/src/helpers/contract.tsis empty
Otherwise, I tested it and there was no change from a user perspective so I guess that's a success. There are quite a few changes so my review isn't very detailed -- it looks good from a high level.
krhoda
force-pushed
the
feat/generalize-claims
branch
3 times, most recently
from
0dfcb4f
to
e63efc8
Compare
|
Also removed the wasm module. Very curious why/how that happened. |
Merged
sbihel
approved these changes
Jun 16, 2021
krhoda
force-pushed
the
feat/generalize-claims
branch
from
e63efc8
to
9fdcb51
Compare
…keeping, and bug fixes
krhoda
force-pushed
the
feat/generalize-claims
branch
from
9fdcb51
to
0a4a818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.