Use proper types for end & start time when mapping ProcessResult

[Chemaclass]

The types are wrong when mapping from the entity to the transfers.

You can clearly see why this can be a problem by looking at the code below:

ProcessResultTransfer::getStartTime(): ?int # Expected to be a unix type
// VS
SpyProcessResultEntityTransfer::getStartTime(): ?string # Expected to be a string date time

[tvaleriy]

Hi Jose Maria! Thank you for your contribution into Spryker! And sorry for the late reply. I'll create an internal ticket for our development team so once they have time they will validate this PR and merge it. I will keep you updated here.

Best,
Spryker Support Team

[dereuromark]

The previous commit Was better.
Empty() should not be used around methods.

[Chemaclass]

@dereuromark I used empty() due to the falsy (I think it was null) for $processResultEntityTransfer->getStartTime() in:

$processResultTransfer->setStartTime(strtotime($processResultEntityTransfer->getStartTime()));

Another alternative avoiding using empty() could be:

if ($processResultEntityTransfer->getStartTime()) {
  $processResultTransfer->setStartTime(strtotime($processResultEntityTransfer->getStartTime()));
}

But I don't see a real difference between this ☝️ with or without empty().
And I am curious, why do you say that "Empty() should not be used around methods."?

[dereuromark]

if () or if (!) also works here, and is cleaner as it is non cloaking
See also https://documentation.spryker.com/docs/code-style-guide#comparison

[Chemaclass]

@dereuromark thanks for the link! I updated the PR using !== null instead of empty()