Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-5621: Makes platform detection for WSL2 case-insensitive #341

Merged
merged 1 commit into from
Oct 12, 2022
Merged

SC-5621: Makes platform detection for WSL2 case-insensitive #341

merged 1 commit into from
Oct 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 28, 2022

Description

Issue: https://spryker.atlassian.net/browse/SC-5621

Change log

  • Makes platform detection for WSL2 case-insensitive

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@ghost ghost requested a review from alexanderM91 June 28, 2022 10:01
@alexanderM91 alexanderM91 added bug Something isn't working QA Needs QA before release labels Jun 30, 2022
@alexanderM91 alexanderM91 added ready-for-release ready for release and removed QA Needs QA before release labels Oct 6, 2022
@alexanderM91 alexanderM91 merged commit fe1f5bc into master Oct 12, 2022
@alexanderM91 alexanderM91 deleted the bugfix/sc-5621/platform-detection-case-insensitive branch October 12, 2022 09:03
@fsmeier fsmeier mentioned this pull request Jan 11, 2023
Closed
@cboursinos
Copy link

Not fixing the issue with WSL2, also creates more problems. Needs revert back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working ready-for-release ready for release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cboursinos @alexanderM91 @fsmeier