Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-11253: Optional services #401

Merged
merged 13 commits into from
Jan 11, 2023
Merged

SC-11253: Optional services #401

merged 13 commits into from
Jan 11, 2023

Conversation

zyuzka
Copy link
Contributor

@zyuzka zyuzka commented Dec 9, 2022

Description

Change log

  • cleanup dependency for all applications
  • adjust Data::load function by checking service availability
  • adjust Runtime::waitFor function by checking service availability
  • adjust all Service scripts by checking service availability
  • add ignore missing option to include function
  • cleanup index script

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@zyuzka zyuzka added the improvement Improvement or new feature label Dec 9, 2022
@zyuzka zyuzka self-assigned this Dec 9, 2022
@alexanderM91 alexanderM91 mentioned this pull request Dec 12, 2022
Closed
@pushokwhite pushokwhite mentioned this pull request Dec 21, 2022
Closed
@alexanderM91 alexanderM91 added the documentation Improvements or additions to documentation label Jan 4, 2023
@alexanderM91 alexanderM91 added ready-for-release ready for release and removed documentation Improvements or additions to documentation labels Jan 9, 2023
@alexanderM91 alexanderM91 changed the title SC-11253: make services optional on docker sdk SC-11253: Optional services Jan 9, 2023
@alexanderM91 alexanderM91 merged commit 37a8da1 into master Jan 11, 2023
@alexanderM91 alexanderM91 deleted the feature/sc-11253/master-make-services-optional-on-docker-sdk branch January 11, 2023 14:39
fsmeier
fsmeier reviewed Feb 8, 2023
View reviewed changes
docs/06-configuring-services.md
@@ -146,6 +147,12 @@ services:
protocol: tcp
```

2. Bootstrap the docker setup and rebuild the application:
```bash
docker/sdk boot deploy.*.yml &&\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, docker/sdk boot is not listed in the official list of docker-sdk commands and in most documentation it got changed from boot (older way?) to bootstrap. We should stick to one writing, otherwise this sparks confusion

@kalaputsik kalaputsik mentioned this pull request Apr 6, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsmeier fsmeier fsmeier left review comments

@alexanderM91 alexanderM91 alexanderM91 approved these changes

Assignees

@zyuzka zyuzka

Labels
improvement Improvement or new feature ready-for-release ready for release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zyuzka @fsmeier @alexanderM91 @andriitserkovnyi