Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactored layout #279

Merged
merged 97 commits into from
May 10, 2023
Merged

chore: refactored layout #279

merged 97 commits into from
May 10, 2023

Conversation

tobi-or-not-tobi
Copy link
Contributor

@tobi-or-not-tobi tobi-or-not-tobi commented Apr 18, 2023

Changes:

  • Responsive layouts are back
  • Layout specific styles are only applied when needed (e.g. grid vs carousel vs column, etc) and do not pollute the DOM unnecessarily
  • Screen size driven styles are added only when used; each screen size can contribute to the base styles regardless.
  • The grid system has been refactored to better calculate the grid size; the column width is calculated by the root container size to ensure a consistent width, but will at the same time not leak out of the available space. As a result, the layout of PLP is much more stable.
  • Page bleeding is introduced (formerly known as max-size) to align better with industry naming. Also, carousel now allows to bleed out to have carousel items running outside the container size.
  • Layout style rules are now created by the layout logic (controller, service) and can be conveniently applied by the new LayoutMixin; other components (like the product list) only need to leverage the LayoutMixin to leverage layout.
  • The Layout component is no longer used inside compositions and the product list component, instead new layout mixin is used. This avoid additional DOM nodes for every composition.
  • PropertySignals are used to observe property updates directly inside signal logic.
  • Layout types and layout properties (sticky, bleed, overlap) are provided by options or properties and can be refined per screen size. xs, xm, md, lg and xl are standard supported screen sizes.
  • Tabular styles are dropped for the moment as they do not fit with the new design; they will come back (similar to accordions whenever we roll out the concept of layout plugins).
  • New overlap layout feature introduce to have multiple layouts on top of each other.

closes HRZ-2719, HRZ-2708
fixes HRZ-2737

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 304b40c
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/645bf642f98dfe00084a6009
😎 Deploy Preview https://deploy-preview-279--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 304b40c
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/645bf6421f6f7c000957a4b4
😎 Deploy Preview https://deploy-preview-279--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 18, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 304b40c
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/645bf6427b70c400080e8fb4
😎 Deploy Preview https://deploy-preview-279--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tobi-or-not-tobi tobi-or-not-tobi marked this pull request as ready for review May 7, 2023 09:31
supproduction
supproduction previously approved these changes May 10, 2023
@tobi-or-not-tobi tobi-or-not-tobi merged commit 3edd4e3 into development May 10, 2023
@tobi-or-not-tobi tobi-or-not-tobi deleted the feature/layout-3.0 branch May 10, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants