Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: e2e partial picking #290

Merged
merged 11 commits into from
May 2, 2023
Merged

Conversation

tarashaliuk
Copy link
Contributor

@tarashaliuk tarashaliuk commented Apr 21, 2023

closes: HRZ-2716

@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit a3b8e77
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/6450e97443ab5e00083a56ef
😎 Deploy Preview https://deploy-preview-290--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit a3b8e77
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/6450e97427ddbd0008536c67
😎 Deploy Preview https://deploy-preview-290--dev-fulfillment.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit a3b8e77
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/6450e974f4008c0008d982f4
😎 Deploy Preview https://deploy-preview-290--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 21, 2023

Deploy Preview for dev-composable-storefront-labs ready!

Name Link
🔨 Latest commit a3b8e77
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront-labs/deploys/6450e9741c00ab0008a57e6c
😎 Deploy Preview https://deploy-preview-290--dev-composable-storefront-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

# Conflicts:
#	apps/fulfillment-e2e/src/support/page_fragments/picking.fragment.ts
@Sinucid Sinucid self-requested a review April 24, 2023 08:03
Sinucid
Sinucid previously approved these changes Apr 24, 2023
@Sinucid Sinucid self-requested a review April 24, 2023 08:04
Copy link
Contributor

@Sinucid Sinucid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e is broken now

Copy link
Contributor

@AndreyYevtukhov AndreyYevtukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a call to discuss

Copy link
Contributor

@AndreyYevtukhov AndreyYevtukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes are needed. We can have a short pair-programming session and do it together if you want :)

I'll add some details and thoughts so that it is easier to do it next time)

Copy link
Contributor

@AndreyYevtukhov AndreyYevtukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small change, and we are done here :)

@tarashaliuk tarashaliuk merged commit 1604bb4 into development May 2, 2023
@tarashaliuk tarashaliuk deleted the feature/hrz-2716-partial-picking branch May 2, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants