-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: e2e partial picking #290
Conversation
✅ Deploy Preview for dev-composable-storefront ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for dev-fulfillment ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for dev-oryx-components ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for dev-composable-storefront-labs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
# Conflicts: # apps/fulfillment-e2e/src/support/page_fragments/picking.fragment.ts
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e is broken now
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have a call to discuss
apps/fulfillment-e2e/src/integration/fully-picking-a-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
apps/fulfillment-e2e/src/integration/partialy-picking-picklist.cy.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes are needed. We can have a short pair-programming session and do it together if you want :)
I'll add some details and thoughts so that it is easier to do it next time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last small change, and we are done here :)
closes: HRZ-2716