Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e tests for picking lists search functionality #349

Merged

Conversation

nsilva-spryker
Copy link
Contributor

@nsilva-spryker nsilva-spryker commented May 17, 2023

Add e2e tests for picking lists search functionality.
Refactor proper header title.

Close HRZ-2825

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit 62c7232
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/646770b6b8014900081bd0d5
😎 Deploy Preview https://deploy-preview-349--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for dev-composable-storefront-labs ready!

Name Link
🔨 Latest commit 62c7232
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront-labs/deploys/646770b6519d8a00089afc5e
😎 Deploy Preview https://deploy-preview-349--dev-composable-storefront-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit 62c7232
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/646770b66eafc00008b3fbb0
😎 Deploy Preview https://deploy-preview-349--dev-composable-storefront.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 17, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit 62c7232
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/646770b6e472c400081d1ec3
😎 Deploy Preview https://deploy-preview-349--dev-fulfillment.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@AndreyYevtukhov AndreyYevtukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small suggestions

Copy link
Contributor

@AndreyYevtukhov AndreyYevtukhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 super small leftovers

@nsilva-spryker nsilva-spryker dismissed AndreyYevtukhov’s stale review May 19, 2023 16:15

Andrii on sick leave, already resolved comments, approved by Alex

@nsilva-spryker nsilva-spryker merged commit 4f34781 into development May 19, 2023
@nsilva-spryker nsilva-spryker deleted the feature/hrz-2825-e2e-tests-picking-lists-search branch May 19, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants