Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update modal bleed for fulfillment #651

Merged

Conversation

aleespryker
Copy link
Contributor

@aleespryker aleespryker commented Jul 27, 2023

A minimum modal must have a little bleed to not stick to the window.

closes: HRZ-3319

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for dev-oryx-components ready!

Name Link
🔨 Latest commit e207f1a
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/64c3945a44930c0008de7e57
😎 Deploy Preview https://deploy-preview-651--dev-oryx-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for dev-composable-storefront ready!

Name Link
🔨 Latest commit e207f1a
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/64c3945a44930c0008de7e5c
😎 Deploy Preview https://deploy-preview-651--dev-composable-storefront.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for dev-fulfillment ready!

Name Link
🔨 Latest commit e207f1a
🔍 Latest deploy log https://app.netlify.com/sites/dev-fulfillment/deploys/64c3945a9515d300085bab36
😎 Deploy Preview https://deploy-preview-651--dev-fulfillment.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Jul 27, 2023

Passing run #9144 ↗︎

0 14 36 0 Flakiness 0

Details:

fix: apply margins to minimal modals
Project: Composable Storefront Commit: e207f1ad53
Status: Passed Duration: 03:32 💡
Started: Jul 28, 2023 10:16 AM Ended: Jul 28, 2023 10:20 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Jul 27, 2023

1 flaky tests on run #1925 ↗︎

0 27 0 0 Flakiness 1

Details:

fix: apply margins to minimal modals
Project: Fulfillment App Commit: e207f1ad53
Status: Passed Duration: 05:54 💡
Started: Jul 28, 2023 10:39 AM Ended: Jul 28, 2023 10:45 AM
Flakiness  src/integration/partialy-picking-picklist.cy.ts • 1 flaky test • fa-regression

View Output Video

Test Artifacts
Partial picking a picklist > should check partial picking Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@aleespryker aleespryker merged commit 1e06b7a into development Jul 28, 2023
28 checks passed
@aleespryker aleespryker deleted the bugfix/hrz-3319-update-fulfillment-modal-bleed branch July 28, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants