Make Moto (tests) compatible with flask/werkzeug 2.x #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
fix-flaskwerkzeug-dependency
branch
from
a263359
to
1a31519
Compare
This reverts commit 8bb0feb.
bblommers
force-pushed
the
fix-flaskwerkzeug-dependency
branch
from
4ec2fa9
to
b0a5d6c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3923 +/- ##
=======================================
Coverage 94.85% 94.86%
=======================================
Files 454 454
Lines 49275 49312 +37
=======================================
+ Hits 46741 46778 +37
Misses 2534 2534
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bblommers
changed the title
|
This is now part of moto >= 2.0.8.dev3 |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
May 15, 2021
Although a upstream dev got test failures with werkzeug/flask 2.0 [1], all tests, including `managedblockchain` ones, are green on my machine. [1] getmoto/moto#3923 git-svn-id: file:///srv/repos/svn-community/svn@934603 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
May 15, 2021
Although a upstream dev got test failures with werkzeug/flask 2.0 [1], all tests, including `managedblockchain` ones, are green on my machine. [1] getmoto/moto#3923 git-svn-id: file:///srv/repos/svn-community/svn@934603 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3921
With this PR, moto will werk with both flask/werkzeug 1.x, and flask/werkzeug 2.x.
Issues encountered while trying to fix this
Problem: CodeCov throws an error for some builds:
{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}Solution:
Problem:
test_s3_server_post_without_content_lengthfails with werkzeug 2.x/flash 1.xSolution: Described in #3921
Problem:
managedblockchainerror handling fails in werkzeug 2.xUnderlying cause:
This service would return XML-errors, when boto3 expects them in JSON format. This would cause boto3 to throw an error saying:
Unable to validate response: <error>Can't find network x</error>With werkzeug 2.x, some encoding acts differently, and the error returned suddenly looks like:
Unable to validate response: <error>Can"t find network x</error>This caused the asserts to fail, as the error message no longer matches up.
Solution:
Rewrite all error scenarios to return JSON-formatted errors, and rewrite the tests to assert this is done correctly