PR: Default icon color to application palette #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default values for the icon color match the application palette
dalthviz
changed the title
ccordoba12
reviewed
Oct 21, 2021
There was a problem hiding this comment.
Thanks @dalthviz for this! I left some minor suggestions for you, otherwise looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
dalthviz
changed the title
…ault options and update test for the icon browser
dalthviz
changed the title
ccordoba12
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values for the icon color match the application palette
Fixes #156
Supersedes/continuation #157
Preview: