Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Handle PySide2 not having QtGui.QGlyphRun and add tests jobs with PySide2 #211

Merged
merged 6 commits into from
Oct 20, 2022

Conversation

dalthviz
Copy link
Member

Fixes #210

@dalthviz dalthviz added this to the v1.2.1 milestone Oct 19, 2022
@dalthviz dalthviz self-assigned this Oct 19, 2022
@dalthviz dalthviz changed the title PR: Handle PySide2 not having 'QtGui.QGlyphRun' and add tests jobs with PySide2 PR: Handle PySide2 not having QtGui.QGlyphRun and add tests jobs with PySide2 Oct 19, 2022
@dalthviz dalthviz mentioned this pull request Oct 20, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for the quick fix!

qtawesome/iconic_font.py Outdated Show resolved Hide resolved
qtawesome/iconic_font.py Outdated Show resolved Hide resolved
requirements/environment.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 5a31b9d into spyder-ide:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QtAwesome 1.2.0 incompatible with PySide2
2 participants