Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del some names in QtCore ? #35

Closed
Nodd opened this issue Jun 11, 2016 · 5 comments
Closed

del some names in QtCore ? #35

Nodd opened this issue Jun 11, 2016 · 5 comments

Comments

@Nodd
Copy link
Contributor

Nodd commented Jun 11, 2016

In QtCore.py a few variables are renamed but the old names still persist, like pyqtSignal and Signal. PyQt variants should be removed.
(PyQt variants are imported by import *)

@ccordoba12
Copy link
Member

+1 to this. PR coming? ;-)

@Nodd
Copy link
Contributor Author

Nodd commented Jun 11, 2016

Maybe after #33 :oP

@goanpeca
Copy link
Member

Should we "manually" import all items? instead of * and deleting? (yes more work but also more explicit)

@Nodd
Copy link
Contributor Author

Nodd commented Jun 11, 2016

It would help for autocompletion.
If we do this, there should be one item per line, so that later modifications show clearly what is modified. That's the theory, maybe having too many lines will hurt more than help.
PR coming? ;-)

@goanpeca
Copy link
Member

:-)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants