Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PyQt variant symbols from QtCore #47

Merged
merged 2 commits into from
Jul 7, 2016

Conversation

Nodd
Copy link
Contributor

@Nodd Nodd commented Jul 6, 2016

Fixes #36.
Fixes #35.

I still think that the duplicate imports are very weird and not needed, But it doesn't hurt too much to leave them.

@ccordoba12 ccordoba12 added this to the v1.1.2 milestone Jul 6, 2016
@ccordoba12
Copy link
Member

Pining @goanpeca because he's trying to use QT_VERSION_STR in Navigator.

@goanpeca
Copy link
Member

goanpeca commented Jul 6, 2016

Oh right I should have used th QT4 constants

@Nodd
Copy link
Contributor Author

Nodd commented Jul 7, 2016

Let's wait that the navigator is fixed before merging then.

@goanpeca
Copy link
Member

goanpeca commented Jul 7, 2016

Fixed on my side

@ccordoba12 ccordoba12 changed the title Pyqtvariants Remove PyQt variant symbols from QtCore Jul 7, 2016
@ccordoba12 ccordoba12 merged commit a6750d6 into spyder-ide:master Jul 7, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants