-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Handle QtCore.SignalInstance/pyqtBoundSignal #214
Conversation
Hi @altendky thanks for the contribution. What is this exactly addressing 🙃 ? |
I was trying to type hint a function that takes a signal as a parameter. The object you get when you I'm not actually running mypy on this project yet but I think I'll need to do something over in the stubs as well based on PyCharm being a bit confused as is. (or maybe I just haven't installed the third-party stubs yet and that'll help out). |
Ok understood. Anything that we could do on our side with MyPy to help with this? |
I really don't know. I've only touched mypy a little bit at this point. If I find something that seems like it would be best fixed here, I'll let you know. :] For now, just having a single way to refer to the 'signal instance' class would address my immediate need. (well, I worked around it with a quick if in my own code so I'm not being held up). |
@altendky ok, so far this looks ok, will merge. A new release will be available in a couple of weeks while I do some cleanup of other PRs. Thanks again! |
We have some simple tests that check that things are imported. Could you add one? |
Yeah, I saw that but didn't see a lot so I skipped them. Should be an easy add. Maybe in a few hours here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that test now clarifies everything :-)
Merging!
No description provided.