Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Allow magic to edit locals while debugging #481

Merged
merged 7 commits into from
Mar 13, 2024
Merged

PR: Allow magic to edit locals while debugging #481

merged 7 commits into from
Mar 13, 2024

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Mar 12, 2024 •
edited
Loading

@impact27 impact27 mentioned this pull request Mar 12, 2024
Merged
ccordoba12
ccordoba12 reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27! Two small suggestions for you, otherwise looks good to me.

spyder_kernels/customize/spyderpdb.py Outdated Show resolved Hide resolved
spyder_kernels/customize/utils.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v3.0.0b5 milestone Mar 13, 2024
@ccordoba12 ccordoba12 changed the title PR: allow magic to edit locals while debugging PR: Allow magic to edit locals while debugging Mar 13, 2024
@ccordoba12 ccordoba12 added the type:Enhancement New feature or request label Mar 13, 2024
impact27 and others added 2 commits March 13, 2024 06:51
@impact27 @ccordoba12
Apply suggestions from code review
363e87b 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
cleanup
7d8d2d5
@impact27
Copy link
Contributor Author

@ccordoba12 I tried to expend a bit on the comments. Also I moved __spyder_builtins__ so it can not be missing.

ccordoba12
ccordoba12 reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small suggestions, then this should be ready.

impact27 and others added 2 commits March 13, 2024 16:59
@impact27 @ccordoba12
Update spyder_kernels/customize/utils.py
e37282c 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@impact27 @ccordoba12
Update spyder_kernels/customize/utils.py
cf54007 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
ccordoba12 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @impact27!

@ccordoba12 ccordoba12 merged commit afbca2e into spyder-ide:master Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@impact27 impact27

Labels
type:Enhancement New feature or request
Projects
None yet
Milestone
v3.0.0b5
Development

Successfully merging this pull request may close these issues.
2 participants
@impact27 @ccordoba12