PR: Enable comms to work across different Python versions #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2024
Merged
impact27
changed the title
ccordoba12
reviewed
May 28, 2024
There was a problem hiding this comment.
Thanks @impact27 for your hard work on this! I only small formatting suggestions and a question for you.
| @@ -346,14 +350,21 @@ def get_var_properties(self): | |||
| return None | |||
|
|
|||
| @comm_handler | |||
| def get_value(self, name): | |||
| def get_value(self, name, encoded=False): | |||
There was a problem hiding this comment.
Why encoded is False by default and not True? Don't we need all values to be encoded with Cloudpickle?
There was a problem hiding this comment.
get_value is also used in spyder_kernels e.g. in the tests where there is no need for encoding. Only the comm call requires encoding. The extra bonus is that it makes the encoding explicit on the frontend side
ccordoba12
changed the title
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudpickle only works when the exact same version of python is used. Replaced with json.
This creates a bit more work because all the input and output of comms must be json serialisable or bytes
Goes with spyder-ide/spyder#22120
Fixes #468
FrameSummary are not compatible between versions of python. This change follows the doc here: https://docs.python.org/3/library/traceback.html#traceback.FrameSummary