-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Enable comms to work across different Python versions (IPython console) #22120
Conversation
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "a601d4633" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "a601d4633" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "931e6e880" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "931e6e880" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "8edb4c210" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "8edb4c210" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-05-29 04:08:12 UTC |
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "4cc697fc8" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "4cc697fc8" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "4f41ea9f6" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "4f41ea9f6" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "5382aa6c4" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "5382aa6c4" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "d04b8e27d" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "d04b8e27d" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "c3b94357e" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "c3b94357e" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "ab7ce7c6d" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "ab7ce7c6d" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "435575e27" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "435575e27" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "7a8ad4274" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "7a8ad4274" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "872f5a325" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "872f5a325" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "674f60de8" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "674f60de8" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
…com/impact27/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "94d107e4f" upstream: origin: "https://github.com/impact27/spyder-kernels.git" branch: "SpyderFrameSummary" commit: "94d107e4f" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @impact27! A few code style suggestions for you, the rest looks to me.
…spyder-ide/spyder-kernels.git external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "cf597289f" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "cf597289f" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @impact27!
Description of Changes
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: