PR: runcell trigger post_execute before run_cell to end the run_cell pre_execute #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
ccordoba12
changed the title
ccordoba12
reviewed
Oct 19, 2018
| @@ -711,6 +711,11 @@ def runcell(cellname, filename): | |||
| "Please use only through Spyder's Editor; " | |||
| "shouldn't be called manually from the console") | |||
| return | |||
|
|
|||
| # Trigger `post_execute` to exit the additional pre-execution. | |||
| # See spyder #7310. | |||
There was a problem hiding this comment.
Please add issue here to be easily grep-able, i.e.
See Spyder issue #7310
There was a problem hiding this comment.
Since #7310 is a pull request, would be be better as:
See Spyder pull request #7310
There was a problem hiding this comment.
Sorry, I didn't know that. Let's use then PR #7310.
ccordoba12
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here:
spyder-ide/spyder#7310
This is the simple fix:
Pull request coming to spyder-kernels.
The new runcell command runs the pre-execution trigger 3 times (and now closes twice) before every execution, but I don't notice any performance hit.