Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: runcell trigger post_execute before run_cell to end the run_cell pre_execute #58

Merged
merged 2 commits into from
Oct 19, 2018
Merged

PR: runcell trigger post_execute before run_cell to end the run_cell pre_execute #58

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05cc21f
Trigger post_execute before run_cell to end the run_cell pre_execute
bcolsen Oct 18, 2018
dbd9127
Doc fixes
bcolsen Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions spyder_kernels/customize/spydercustomize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,11 @@ def runcell(cellname, filename):
"Please use only through Spyder's Editor; "
"shouldn't be called manually from the console")
return

# Trigger `post_execute` to exit the additional pre-execution.
# See spyder #7310.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add issue here to be easily grep-able, i.e.

See Spyder issue #7310

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #7310 is a pull request, would be be better as:

See Spyder pull request #7310

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't know that. Let's use then PR #7310.

ipython_shell.events.trigger('post_execute')

ipython_shell.run_cell(cell_code)
del ipython_shell.cell_code

Expand Down