Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Migrate to the new Spyder 5 API #369

Merged
merged 12 commits into from
Sep 2, 2022
Merged

PR: Migrate to the new Spyder 5 API #369

merged 12 commits into from
Sep 2, 2022

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jun 22, 2021 •
edited
Loading

This PR also drops support for Python 3.6.

Fixes #360.

TODO:

  • Move switcher handling to NotebookMainWidget
  • Fix tests.
  • Fix layout in Spyder to position it correctly next to the editor.
  • Fix pep8speaks warnings

@ccordoba12 ccordoba12 added this to the v0.4 milestone Jun 22, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 22, 2021 •
edited
Loading

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 271:80: E501 line too long (84 > 79 characters)

Comment last updated at 2022-09-02 18:56:50 UTC

@ccordoba12 ccordoba12 self-assigned this Jun 22, 2021
This was referenced Nov 9, 2021
Closed
Closed
@ccordoba12 ccordoba12 mentioned this pull request Dec 24, 2021
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #369 (a0ec798) into master (047b775) will decrease coverage by 0.17%.
The diff coverage is 81.71%.

Impacted Files Coverage Δ
spyder_notebook/notebookplugin.py 75.47% <73.91%> (-5.12%) ⬇️
spyder_notebook/widgets/main_widget.py 80.00% <80.00%> (ø)
spyder_notebook/_version.py 100.00% <100.00%> (ø)
spyder_notebook/config.py 100.00% <100.00%> (ø)
spyder_notebook/confpage.py 100.00% <100.00%> (ø)
spyder_notebook/utils/servermanager.py 97.39% <100.00%> (ø)
spyder_notebook/widgets/client.py 74.86% <100.00%> (+0.72%) ⬆️
spyder_notebook/widgets/notebooktabwidget.py 92.00% <100.00%> (+1.44%) ⬆️

@ccordoba12 ccordoba12 mentioned this pull request Jul 4, 2022
Merged
@ccordoba12 ccordoba12 mentioned this pull request Aug 27, 2022
Closed
@ccordoba12 ccordoba12 merged commit 5dc3696 into spyder-ide:master Sep 2, 2022
@ccordoba12 ccordoba12 deleted the new-api branch September 2, 2022 19:12
jitseniesen added a commit to jitseniesen/spyder-notebook that referenced this pull request Apr 1, 2023
@jitseniesen
Add New/Open Notebook items to notebook context menu
738a3eb 
These entries were accidentally removed in PR spyder-ide#369.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ccordoba12 ccordoba12

Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Support Spyder 5
3 participants
@ccordoba12 @pep8speaks @codecov-commenter