PR: Enable CircleCI and first tests addition #30
Conversation
circle.yml
Outdated
| # The last container is used to test with pyqt5 wheels | ||
| PY_VERSIONS: "2.7 3.6 3.5" | ||
| # For Coveralls | ||
| COVERALLS_REPO_TOKEN: sTGxv5iQxuiBQCoxLB53t6m2xSe58rAIq |
There was a problem hiding this comment.
This token should be deleted from here (and regenerated), and added instead to https://circleci.com/gh/spyder-ide/spyder-vim/edit#env-vars
.checkignore
Outdated
| @@ -0,0 +1,16 @@ | |||
| # Quantified code ignore file | |||
There was a problem hiding this comment.
Please remove this file. Quantified Code was closed.
There was a problem hiding this comment.
Maybe we could use Scrutinizer in the plugins as qtpy does (It's somehow similar)
|
Now you need to fix all style issue reported by |
setup.py
Outdated
|
|
||
| setup( | ||
| name='spyder.vim', | ||
| version="0.1.0", | ||
| name='spyder_vim', |
There was a problem hiding this comment.
This needs to be spyder-vim, not spyder_vim
There was a problem hiding this comment.
Then I should also update spyder-terminal then!
There was a problem hiding this comment.
Please open an issue about it before doing it. I don't know if it's possible at this point.
There was a problem hiding this comment.
It seems that the package is right: https://pypi.python.org/pypi/spyder-terminal
There was a problem hiding this comment.
Great! Then it's probably safe to do it ;-)
setup.py
Outdated
| packages=find_packages(exclude=['contrib', 'docs', 'tests*']), | ||
| keywords=["spyder ide plugin addon vi vim"], | ||
| url='https://github.com/Nodd/spyderplugins.vim', | ||
| keywords=['Spyder', 'Plugin'], |
Fixes #24
Fixes #27