Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add cursor screen movements #62

Merged
merged 7 commits into from Jun 22, 2020
Merged

PR: Add cursor screen movements #62

merged 7 commits into from Jun 22, 2020

Conversation

bgallois
Copy link
Collaborator

Added cursor screen movements:

  • H move to the top of the screen
  • M move to the middle of the screen
  • L move to the bottom of the screen
  • zz center current line

@bgallois bgallois changed the title Add screen movement PR: Add cursor screen movements Jun 21, 2020
ccordoba12
ccordoba12 reviewed Jun 21, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgallois, thanks a lot for your continued work on this plugin! I left a minor comment for you.

Also, any chance to add a test for the new zz command?

spyder_vim/tests/test_vim.py Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 added this to the v0.1 milestone Jun 21, 2020
@bgallois bgallois marked this pull request as draft June 21, 2020 19:59
@bgallois bgallois force-pushed the add_screen_movement branch 2 times, most recently from f52e00c to aac2294 Compare June 21, 2020 20:15
@bgallois bgallois marked this pull request as ready for review June 21, 2020 20:23
@bgallois
Copy link
Collaborator Author

@ccordoba12 I added a test for the zz command and corrected the docstring. Also fixed the test for the H L and M commands.

ccordoba12
ccordoba12 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bgallois! Looks good to me now.

@ccordoba12 ccordoba12 merged commit 993fa5f into spyder-ide:master Jun 22, 2020
@bgallois bgallois deleted the add_screen_movement branch June 23, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bgallois @ccordoba12