PR: Improve Variable Explorer UX (#20868)

Co-authored-by: Daniel Althviz Moré <d.althviz10@uniandes.edu.co> Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
spyder-ide · Jul 14, 2023 · cf35639 · cf35639
1 parent 6efaff3
commit cf35639
Show file tree

Hide file tree

Showing 11 changed files with 161 additions and 43 deletions.
diff --git a/external-deps/spyder-kernels/.gitrepo b/external-deps/spyder-kernels/.gitrepo
diff --git a/external-deps/spyder-kernels/spyder_kernels/console/tests/test_console_kernel.py b/external-deps/spyder-kernels/spyder_kernels/console/tests/test_console_kernel.py
diff --git a/external-deps/spyder-kernels/spyder_kernels/utils/nsview.py b/external-deps/spyder-kernels/spyder_kernels/utils/nsview.py
diff --git a/spyder/config/main.py b/spyder/config/main.py
@@ -179,7 +179,8 @@
               'truncate': True,
               'minmax': False,
               'show_callable_attributes': True,
-              'show_special_attributes': False
+              'show_special_attributes': False,
+              'filter_on': True
              }),
             ('debugger',
              {

diff --git a/spyder/plugins/ipythonconsole/comms/tests/test_comms.py b/spyder/plugins/ipythonconsole/comms/tests/test_comms.py
@@ -60,7 +60,8 @@ def kernel(request):
             'False_',
             'True_'
         ],
-        'minmax': False}
+        'minmax': False,
+        'filter_on': True}
 
     # Teardown
     def reset_kernel():

diff --git a/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py b/spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py
@@ -1832,7 +1832,8 @@ def test_pdb_comprehension_namespace(ipyconsole, qtbot, tmpdir):
      'excluded_names': [],
      'minmax': False,
      'show_callable_attributes': True,
-     'show_special_attributes': False}
+     'show_special_attributes': False,
+     'filter_on': True}
 
     shell.call_kernel(
             interrupt=True

diff --git a/spyder/plugins/maininterpreter/plugin.py b/spyder/plugins/maininterpreter/plugin.py
@@ -112,11 +112,12 @@ def set_custom_interpreter(self, interpreter):
     def _open_interpreter_preferences(self):
         """Open the Preferences dialog in the main interpreter section."""
         self._main.show_preferences()
-        preferences = self._main.preferences
-        container = preferences.get_container()
-        dlg = container.dialog
-        index = dlg.get_index_by_name("main_interpreter")
-        dlg.set_current_index(index)
+        preferences = self.get_plugin(Plugins.Preferences)
+        if preferences:
+            container = preferences.get_container()
+            dlg = container.dialog
+            index = dlg.get_index_by_name("main_interpreter")
+            dlg.set_current_index(index)
 
     @Slot(str)
     def _add_to_custom_interpreters(self, interpreter):

diff --git a/spyder/plugins/variableexplorer/confpage.py b/spyder/plugins/variableexplorer/confpage.py
@@ -13,15 +13,20 @@
 from spyder.config.base import _
 from spyder.api.preferences import PluginConfigPage
 
+
 class VariableExplorerConfigPage(PluginConfigPage):
 
     def setup_page(self):
         filter_group = QGroupBox(_("Filter"))
         filter_data = [
-            ('exclude_private', _("Exclude private references")),
-            ('exclude_capitalized', _("Exclude capitalized references")),
-            ('exclude_uppercase', _("Exclude all-uppercase references")),
-            ('exclude_unsupported', _("Exclude unsupported data types")),
+            ('exclude_private',
+             _("Exclude private references")),
+            ('exclude_capitalized',
+             _("Exclude capitalized references")),
+            ('exclude_uppercase',
+             _("Exclude all-uppercase references")),
+            ('exclude_unsupported',
+             _("Exclude unsupported data types")),
             ('exclude_callables_and_modules',
              _("Exclude callables and modules"))
         ]

diff --git a/spyder/plugins/variableexplorer/plugin.py b/spyder/plugins/variableexplorer/plugin.py
@@ -47,7 +47,10 @@ def get_icon(self):
         return self.create_icon('dictedit')
 
     def on_initialize(self):
-        pass
+        widget = self.get_widget()
+        widget.sig_open_preferences_requested.connect(
+            self._open_preferences
+        )
 
     @on_plugin_available(plugin=Plugins.Preferences)
     def on_preferences_available(self):
@@ -58,3 +61,15 @@ def on_preferences_available(self):
     def on_preferences_teardown(self):
         preferences = self.get_plugin(Plugins.Preferences)
         preferences.deregister_plugin_preferences(self)
+
+    # ---- Private API
+    # -------------------------------------------------------------------------
+    def _open_preferences(self):
+        """Open the Preferences dialog in the Variable Explorer section."""
+        self._main.show_preferences()
+        preferences = self.get_plugin(Plugins.Preferences)
+        if preferences:
+            container = preferences.get_container()
+            dlg = container.dialog
+            index = dlg.get_index_by_name(self.NAME)
+            dlg.set_current_index(index)