Skip to content

Commit

Permalink
Projects: Fix showing/hiding pane when switching projects if users ha…
Browse files Browse the repository at this point in the history
…ve closed it
  • Loading branch information
ccordoba12 committed Jun 24, 2021
1 parent 24abcde commit ec4df40
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions spyder/plugins/projects/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -513,10 +513,10 @@ def close_project(self):
self.sig_project_closed.emit(path)
self.sig_pythonpath_changed.emit()

if self.get_widget() is not None:
new_state = not self.get_conf('visible_if_project_open')
self.toggle_view(new_state)
self.set_conf('visible_if_project_open', new_state)
# Hide pane.
self.set_conf('visible_if_project_open',
self.get_widget().isVisible())
self.toggle_view(False)

self.get_widget().clear()
self.restart_consoles()
Expand Down Expand Up @@ -640,7 +640,7 @@ def save_config(self):
self.get_widget().treewidget.get_expanded_state())
self.set_conf('scrollbar_position',
self.get_widget().treewidget.get_scrollbar_position())
if self.current_active_project and self.get_widget():
if self.current_active_project:
self.set_conf('visible_if_project_open',
self.get_widget().isVisible())

Expand Down
4 changes: 2 additions & 2 deletions spyder/plugins/projects/tests/test_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def test_close_project_sets_visible_config(projects, tmpdir, value):
if value:
projects.show_explorer()
else:
projects.toggle_view(False)
projects.get_widget().hide()
projects.close_project()
assert projects.get_conf('visible_if_project_open') == value

Expand All @@ -163,7 +163,7 @@ def test_on_close_sets_visible_config(projects, tmpdir, value):
if value:
projects.show_explorer()
else:
projects.toggle_view(False)
projects.get_widget().hide()
projects.close_project()
assert projects.get_conf('visible_if_project_open') == value

Expand Down

0 comments on commit ec4df40

Please sign in to comment.