Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyboardInterrupt error in waitingspinner #5114

Closed
leotsukada opened this issue Sep 2, 2017 · 7 comments
Closed

KeyboardInterrupt error in waitingspinner #5114

leotsukada opened this issue Sep 2, 2017 · 7 comments

Comments

@leotsukada
Copy link

Description

What steps will reproduce the problem?

What is the expected output? What do you see instead?

Please provide any additional information below

File "/Users/Leo/anaconda/lib/python3.6/site-packages/spyder/widgets/waitingspinner.py", line 177, in rotate
def rotate(self):
KeyboardInterrupt

Version and main components

  • Spyder Version: 3.2.0
  • Python Version: 3.6.2
  • Qt Versions: 5.6.2, PyQt5 5.6 on Darwin

Dependencies

pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1.7      :  1.13.1 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.5 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
psutil >=0.3     :  5.2.2 (OK)
nbconvert >=4.0  :  5.2.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.26 (OK)
qtconsole >=4.2.0:  4.3.0 (OK)
IPython >=4.0    :  6.1.0 (OK)
pylint >=0.25    :  1.7.2 (OK)

@ccordoba12 ccordoba12 changed the title An error in Spyder 3 KeyboardInterrupt error in waitingspinner Sep 3, 2017
@ccordoba12 ccordoba12 added this to the v3.2.x milestone Sep 3, 2017
@ccordoba12
Copy link
Member

Thanks for reporting. We'll take a look at this in a future release.

@rlaverde
Copy link
Member

rlaverde commented Sep 3, 2017

I think this is caused because the waiting spinner is started in the creation of find in files, and never stopped (only the progress bar is hidden/shown) https://github.com/spyder-ide/spyder/blob/3.x/spyder/widgets/findinfiles.py#L784

@ccordoba12
Copy link
Member

Thanks for noticing @rlaverde! Should we stop it then after it's hidden?

@rlaverde
Copy link
Member

rlaverde commented Sep 4, 2017

Yes, start it when progress bar is shown and stop it when progress bar is hidden.

Although if you press Ctrl+C while it's shown and spinning (i.e. searching in files) the error will occur

@goanpeca
Copy link
Member

goanpeca commented Sep 4, 2017

Although if you press Ctrl+C while it's shown and spinning (i.e. searching in files) the error will occur

We should be able to prevent this. https://forum.qt.io/topic/532/how-to-catch-ctrl-c-on-a-widget/3

@ccordoba12 ccordoba12 modified the milestones: v3.2.3, v3.2.x Sep 4, 2017
@rlaverde
Copy link
Member

rlaverde commented Sep 4, 2017

@goanpeca I'm not sure If that will work, the error occur when trying to kill spyder process (pressing Ctrl+C in the terminal that is running spyder).

I don't know if maybe another event raise this error, neither this issue or #5049, have steps to reproduce the error.

@goanpeca
Copy link
Member

goanpeca commented Sep 4, 2017

ahhh @rlaverde ok I understand. Actually I think that is a spyder bug, we should be able to kill spyder from the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants