PR: Make Ctrl+C to quit Spyder on Posix systems #5159
Conversation
spyder/app/mainwindow.py
Outdated
| @@ -288,6 +288,7 @@ def signal_handler(signum, frame=None): | |||
| pass | |||
| else: | |||
| signal.signal(signal.SIGTERM, signal_handler) | |||
| signal.signal(signal.SIGINT, signal_handler) | |||
There was a problem hiding this comment.
Please change this to
if not DEV:
...
There was a problem hiding this comment.
Because it's useful to have it when working in DEV mode. That way you can get a traceback when Spyder freezes for whatever reason.
There was a problem hiding this comment.
Because it's useful to have it when working in DEV mode. That way you can get a traceback when Spyder freezes for whatever reason.
Still this is very unconventional behavior. I am sure there must be a way where we can get a traceback AND quit...
There was a problem hiding this comment.
I think very few people uses DEV, so I don't think we should look for more.
There was a problem hiding this comment.
could we do that? raise something print the output,, wait a bit and then close spyder?
There was a problem hiding this comment.
Hmm yes, raising a exception in the internal console will make spyder quit, although the traceback won't correspond 😕
There was a problem hiding this comment.
Hmm yes, raising a exception in the internal console will make spyder quit, although the traceback won't correspond 😕
Then it is not the solution I "requested"!
There was a problem hiding this comment.
We could also print the other traceback, although I don't like that option.
Maybe skipping the keyboard error where internal console catch errors, although I don't understand the internals of the console and idk if it's possible
There was a problem hiding this comment.
@rlaverde, please finish this one with my initial suggestion. I know that's not ideal, but it will affect mainly to us.
spyder/app/mainwindow.py
Outdated
| signal.signal(signal.SIGINT, signal_handler) | ||
| if not DEV: | ||
| # Make spyder quit when presing ctrl+C in the console | ||
| # In DEV because Ctrl+C doens't quit, because it helps to |
There was a problem hiding this comment.
Please remove the first because in this line.
There was a problem hiding this comment.
This also needs a rebase against 3.x to fix the error in Circle.
ccordoba12
changed the title
ccordoba12
changed the title
…raceback when spyder freezes, see: spyder-ide#5129).
rlaverde
force-pushed
the
keyboard-interrupt
branch
from
5643448
to
e228150
Compare
Fixes #5305
Related to #5114
See: #5129 (comment)