Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add LSP support for handling jedi script extra paths and environment #10629

Merged
merged 17 commits into from
Nov 17, 2019

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Nov 6, 2019

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)

Issue(s) Resolved

Fixes #10299
Fixes #10646
Fixes #1004

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@pep8speaks
Copy link

pep8speaks commented Nov 6, 2019

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-17 22:43:56 UTC

@goanpeca goanpeca self-assigned this Nov 6, 2019
@goanpeca goanpeca added this to the v4.0.0 milestone Nov 6, 2019
@ccordoba12
Copy link
Member

@goanpeca, before reviewing this PR, I'd like for you to implement the changes we talked about on your PyLS PR, so we can test both PRs at the same time.

@goanpeca
Copy link
Member Author

before reviewing this PR, I'd like for you to implement the changes we talked about on your PyLS PR, so we can test both PRs at the same time.

Yes, working on this now

@goanpeca
Copy link
Member Author

@ccordoba12 test passed :-) this one is ready!

@ccordoba12 ccordoba12 mentioned this pull request Nov 17, 2019
30 tasks
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @goanpeca!! This is a fantastic addition!

@ccordoba12 ccordoba12 merged commit 44c8b67 into spyder-ide:master Nov 17, 2019
@goanpeca goanpeca deleted the enh/jedi-path-env branch July 19, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants