Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Use IPython completer for Pdb #10695

Merged
merged 10 commits into from
Nov 15, 2019
Merged

PR: Use IPython completer for Pdb #10695

merged 10 commits into from
Nov 15, 2019

Conversation

impact27
Copy link
Contributor

@impact27 impact27 commented Nov 13, 2019 •
edited by ccordoba12
Loading

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Depends on spyder-ide/spyder-kernels#182.

Issue(s) Resolved

Fixes #10696

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

@pep8speaks
Copy link

pep8speaks commented Nov 13, 2019 •
edited
Loading

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-15 22:00:01 UTC

@impact27 impact27 closed this Nov 13, 2019
@impact27 impact27 reopened this Nov 13, 2019
@ccordoba12 ccordoba12 changed the title PR: Use ipython complete for Pdb PR: Use IPython complete for Pdb Nov 13, 2019
@ccordoba12 ccordoba12 added this to the v4.0rc2 milestone Nov 13, 2019
@ccordoba12 ccordoba12 changed the title PR: Use IPython complete for Pdb PR: Use IPython completer for Pdb Nov 14, 2019
@ccordoba12
Copy link
Member

@impact27, I solved the comments I left for you because we need to merge ASAP.

@ccordoba12 ccordoba12 merged commit 1b81869 into spyder-ide:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0rc2
Development

Successfully merging this pull request may close these issues.

Pdb and IPython completes are inconsistent
3 participants
@impact27 @pep8speaks @ccordoba12