PR: Move Pylint plugin to new API

[goanpeca]

Description of Changes

• Wrote at least one-line docstrings (for any new functions)
• Added unit test(s) covering the changes (if testable)

• Included a screenshot or animation (if affecting the UI, see Licecap)

Took the opportunity to simplify the buttons so that it is similar to find in files (start/stop are the same button)

Issue(s) Resolved

Depends on #11741
Fixes #12183

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

[pep8speaks]

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-19 17:26:33 UTC

[github-actions]

👈 Launch a Binder instance on this branch

[dalthviz]

@goanpeca left a question and also I think this plugin should use the spinner. Besides that LGTM 👍

[goanpeca]

@goanpeca left a question and also I think this plugin should use the spinner. Besides that LGTM 👍

Thanks for the feedback @dalthviz, made the requested fix.

[dalthviz]

@andfoy @steff456 could you give to this PR a manual test on Linux and Mac? Thanks!

[steff456]

/show binder

[github-actions]

👈 Launch a Binder instance on this branch

[steff456]

Hi @goanpeca and @dalthviz,

With @andfoy we manually review this PR and everything is working as expected.

[dalthviz]

@goanpeca one last comment, please unify the use of " to enclose strings, there is a mix (as an example the pylint main_widget.py in the setup of the actions) and using just " could improve future readability of the code. Thanks!

Edit: As an example the code of the setup method:

spyder/spyder/plugins/pylint/main_widget.py

Lines 418 to 440 in bfdcfd4

	def setup(self, options):
	change_history_depth_action = self.create_action(
	PylintWidgetActions.ChangeHistory,
	text=_("History..."),
	tip=_("Set history maximum entries"),
	icon=self.create_icon('history'),
	triggered=self.change_history_depth,
	)
	self.code_analysis_action = self.create_action(
	PylintWidgetActions.RunCodeAnalysis,
	icon_text=_("Analyze"),
	text=_("Run code analysis"),
	tip=_("Run code analysis"),
	icon=self.create_icon('run'),
	triggered=lambda: self.sig_start_analysis_requested.emit(),
	context=Qt.ApplicationShortcut,
	)
	self.browse_action = self.create_action(
	PylintWidgetActions.BrowseFile,
	text=_('Select Python file'),
	tip=_('Select Python file'),
	icon=self.create_icon('fileopen'),
	triggered=self.select_file,

[goanpeca]

@goanpeca one last comment, please unify the use of " to enclose strings, there is a mix (as an example the pylint main_widget.py in the setup of the actions) and using just " could improve future readability of the code. Thanks!

Fixed @dalthviz.

[dalthviz]

@goanpeca seems like no change regarding the mix of ' and " was added with the rebase, could you check what happen?

[dalthviz]

@goanpeca a comment pointing were the CIs are failing

[dalthviz]

Seems like the replace needs some changes here (this is causing the error in the CIs)

[goanpeca]

Will Fix...!

[dalthviz]

Also, some PEP8 errors raised. I know these kind of things are kind of a pain to change so thanks for the effort 👍

[goanpeca]

No worries @dalthviz, it is how it goes.

Thanks for all the reviewing. You are all doing a great job, and practice makes perfect :-) !

[dalthviz]

@goanpeca checking seems like the selected path in the combobox is not being taken in to account unless you use the Select python file button to update it:

Edit: Seems like the Analyze button always triggers the action using the current filename in the Editor

[goanpeca]

Edit: Seems like the Analyze button always triggers the action using the current filename in the Editor

Bug!

Will fix.

[ccordoba12]

Hey @dalthviz, is this one ready for merge?

[dalthviz]

@ccordoba12 I would say that some testing could be nice, otherwise the missing thing is a squash

[ccordoba12]

Thanks @goanpeca for your work on this PR and @dalthviz for your help to finish it.

I also gave this PR some manual testing too (per @dalthviz's request) and it's working as expected.