Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix some failing tests #13408

Merged
merged 1 commit into from
Jul 29, 2020
Merged

PR: Fix some failing tests #13408

merged 1 commit into from
Jul 29, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Jul 28, 2020 •
edited
Loading

Description of Changes

  • With the latest version of something installed with pip (pandas I guess?) a test broke.
  • Also added a check for another test that was failing randomly.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@pep8speaks
Copy link

pep8speaks commented Jul 28, 2020 •
edited
Loading

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-07-28 22:42:03 UTC

@goanpeca goanpeca self-assigned this Jul 28, 2020
@goanpeca goanpeca added this to the Sprint July milestone Jul 28, 2020
@goanpeca goanpeca force-pushed the fix/pip-failing-test branch 4 times, most recently from 7015369 to 12d5f14 Compare July 28, 2020 21:57
ccordoba12
ccordoba12 reviewed Jul 28, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the test you fixed only failing in master? Or is it failing in 4.x too?

@goanpeca goanpeca changed the base branch from master to 4.x July 28, 2020 22:42
@goanpeca
Copy link
Member Author

goanpeca commented Jul 28, 2020 •
edited
Loading

Is the test you fixed only failing in master? Or is it failing in 4.x too?

I have no idea. I rebased unto 4.x.

@ccordoba12
Copy link
Member

Thanks a lot @goanpeca! I think they are because some tests failed on PR #13407.

@ccordoba12 ccordoba12 changed the title PR: Fix pip failing test PR: Fix some failing tests Jul 28, 2020
@goanpeca goanpeca requested a review from ccordoba12 July 28, 2020 23:03
@goanpeca goanpeca mentioned this pull request Jul 28, 2020
Merged
ccordoba12
ccordoba12 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca!

@ccordoba12 ccordoba12 merged commit e32e828 into spyder-ide:4.x Jul 29, 2020
ccordoba12 added a commit that referenced this pull request Jul 29, 2020
@ccordoba12
Merge from 4.x: PR #13408
583969d
@ccordoba12 ccordoba12 modified the milestones: Sprint July, v4.2.0 Aug 9, 2020
@ccordoba12 ccordoba12 modified the milestones: v4.2.0, v4.1.5 Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@dalthviz dalthviz Awaiting requested review from dalthviz

Assignees

@goanpeca goanpeca

Labels
None yet
Projects
None yet
Milestone
v4.1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@goanpeca @pep8speaks @ccordoba12