Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix parent of project type #13472

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

goanpeca
Copy link
Member

@goanpeca goanpeca commented Aug 4, 2020

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Fixes #13471

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca goanpeca self-assigned this Aug 4, 2020
@goanpeca
Copy link
Member Author

goanpeca commented Aug 4, 2020

@nerohmot this should fix the problem. Thanks for the find!

@goanpeca goanpeca force-pushed the fix/project-open-bug branch 3 times, most recently from 0c7e9c5 to 9ec8f57 Compare August 4, 2020 13:24
@pep8speaks
Copy link

pep8speaks commented Aug 4, 2020

Hello @goanpeca! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 784:9: E303 too many blank lines (2)

Comment last updated at 2020-08-04 14:24:15 UTC

@goanpeca goanpeca force-pushed the fix/project-open-bug branch 2 times, most recently from 933fb2e to c90711a Compare August 4, 2020 14:04
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @goanpeca!

@ccordoba12 ccordoba12 merged commit aadfdc6 into spyder-ide:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recursing problem with new plugin API on master
3 participants